All in one cart/rail patch

MinetestForFun / server-minetestforfun

Repository of the subgame and mods of "MinetestForFun" server

https://www.xorhub.com

The Unlicense

27 stars 10 forks source link

All in one cart/rail patch #499

Closed Coethium closed 8 years ago

Coethium commented 8 years ago

Here is another all-in-one patch, concerning three discuss : #496 #492 #366

Removed PilzAdam's carts
Replaced by SmallJoker's Boost_cart (very very better with CPU !) (https://github.com/SmallJoker/boost_cart)
Modified to fully replace carts
Modified for MFF :
desactivate mesecons
power_rail: accelerate, max_speed set in init.lua
brake_rail: deccelerate, min_speed set in init.lua (so the cart doesn't stop and runs at very low speed)
default:rail / rail_cooper : no friction, keep the current speed
no collision (avoid the "walled_in" bug)

BetterToAutomateTheWorld commented 8 years ago

Awesome work, seems perfect to me ! :)

Need the @crabman77 @LeMagnesium opinions

ghost commented 8 years ago

We need to test that on the server :)

Coethium commented 8 years ago

Yes, it needs to be tested on a real server <-> client configuration. In local it was tested with a velocity about 100 times the walk speed. The cart keeps going out of the rails sometime, but it is quicky replaced on the rail.

ghost commented 8 years ago

Voir avec @Cyberpangolin pour tester sur chlorine.

BetterToAutomateTheWorld commented 8 years ago

Merged, congratulation :)

Cyberpangolin commented 8 years ago

Tested ingame, works almost perfectly! :+1:

Thanks for the patch!