MinetestForFun / server-minetestforfun

Repository of the subgame and mods of "MinetestForFun" server
https://www.xorhub.com
The Unlicense
27 stars 10 forks source link

Woldmap glitches #503

Open Coethium opened 8 years ago

Coethium commented 8 years ago

Often the worldmap is fully of glitches, as on the picture : mff worldmap

This bug seems to exist only at evening/night. So i guess this is a buffer overflow (or similar). The server is rebooted at morning, the buffer/cache is filling up during the day and at random time on evening/night the buffer/cache overflows.

BetterToAutomateTheWorld commented 8 years ago

Knew bug

Yes, this is a knew bug. The occuration of this bug is only when we're doing a manually reboot/merge, and yes, it's often morning or evening :) (when admin and devs are available)

This bug has been explained many times, but you can't know this, for the moment :)

The explanation

Well, it's because of our worldmapper, mtsatellite.

The mtseeder goal is to generate tiles, until the mtseeder isn't done the mtwebmapper can't displayed all levels of tiles.

The problem is : the mtseeder duration is approximativly 15minutes, the server daily reboot is slow because of this, because we wait the entire mtseeder tiles before starting again all servers.

When we reboot manually the server, the mtseeder can't generate all tiles, so the worldmap is displayed in a bugged way.

MTSatellite

To understand better the way MTSatellite works, you can have a look at the project on Bitbucket : https://bitbucket.org/s_l_teichmann/mtsatellite You're welcome if you want to improve it, the daily reboot of our server is really slow :/

I also opened this : https://bitbucket.org/s_l_teichmann/mtsatellite/issues/19/mtseeder-is-really-slow

s-l-teichmann commented 8 years ago

Why do you run mtseeder at every reboot? You only need to do it once. The delta updates are done by mtwebmapper.

BetterToAutomateTheWorld commented 8 years ago

@s-l-teichmann Ok, so if I reboot all of our servers without the mtseeder, can you guarantee the mapper won't have problems ? If yes, I need to try it...

s-l-teichmann commented 8 years ago

To fix the glitch by re-running mtseeder should not be the solution.

Looking at the image i would guess that the colors.txt is out of sync: Some tiles are generated with water other are not.

This may relate to your autocolor generator. You only need to update the colors.txt when you install/remove/updates mods. Blind guess: you re-generate colors.txt every reboot, too? (This also should not be necessary).

BetterToAutomateTheWorld commented 8 years ago

Yes, we regenerate the color.txt at each reboot, it's a really fast operation, less than 10sec needed to recreate the file, so no need to do it manually at each mod textures modification

well, im tweaking our scripts to let mtcolormapper the time to done its job

s-l-teichmann commented 8 years ago

How ever this glitch should not happen. I would search for races between the re-gen of the colors.txt and mapping itself.

BetterToAutomateTheWorld commented 8 years ago

Ok done, to be sure the autocolormapper isn't a problem anymore i let him 30sec to done its work, i will reduce this time after some tests and if the gitch isn't anymore here.

EDIT : New scripts merged to the server

BetterToAutomateTheWorld commented 8 years ago

Fixed, works like a charm! Thanks to everyone

gaelysam commented 7 years ago

Happens again, and very often… worldmap