MinetestForFun / server-minetestforfun

Repository of the subgame and mods of "MinetestForFun" server
https://www.xorhub.com
The Unlicense
27 stars 10 forks source link

Strange things with [IRC] mod #73

Closed BetterToAutomateTheWorld closed 9 years ago

BetterToAutomateTheWorld commented 9 years ago

Strange things happenned with the IRC mod when the server boot :

17:13:32: ACTION[main]:         .__               __                   __
17:13:32: ACTION[main]:   _____ |__| ____   _____/  |_  ____   _______/  |_
17:13:32: ACTION[main]:  /     \|  |/    \_/ __ \   __\/ __ \ /  ___/\   __\
17:13:32: ACTION[main]: |  Y Y  \  |   |  \  ___/|  | \  ___/ \___ \  |  |
17:13:32: ACTION[main]: |__|_|  /__|___|  /\___  >__|  \___  >____  > |__|
17:13:32: ACTION[main]:       \/        \/     \/          \/     \/
17:13:32: ACTION[main]: World at [/home/quentinbd/minetest/worlds/minetestforfun/]
17:13:32: ACTION[main]: Server for gameid="minetestforfun_game" listening on 0.0.0.0:30001.
17:13:45: ACTION[ServerThread]: Updated online player file
17:13:45: ACTION[ServerThread]: There are 12467 registered nodes, items and tools.
== This is a debug line, please check for it ==
nil
=== DEBUG FINISHED ===
17:13:56: ACTION[ServerThread]: IRC: Connected!
.../quentinbd/minetest/bin/../mods/irc/irc/messages.lua:106: bad argument #1 to 'sub' (number expected, got nil)
stack traceback:
        [C]: in function 'sub'
        .../quentinbd/minetest/bin/../mods/irc/irc/messages.lua:106: in function 'fromRFC1459'
        .../quentinbd/minetest/bin/../mods/irc/irc/messages.lua:13: in function 'Message'
        ...home/quentinbd/minetest/bin/../mods/irc/irc/main.lua:165: in function 'think'
        /home/quentinbd/minetest/bin/../mods/irc/init.lua:71: in function </home/quentinbd/minetest/bin/../mods/irc/init.lua:71>
        [C]: in function 'xpcall'
        /home/quentinbd/minetest/bin/../mods/irc/init.lua:71: in function </home/quentinbd/minetest/bin/../mods/irc/init.lua:60>
        (tail call): ?
        .../quentinbd/minetest/bin/../builtin/game/register.lua:341: in function <.../quentinbd/minetest/bin/../builtin/game/register.lua:329>

You can see it also here : http://zerobin.qbuissondebon.info/?82d5718a6d807855#UgLpJ43xJh/PdmwLRixccWH84TzBZ7oo4+dQiaygJo8=

What's happening ?

Lymkwi commented 9 years ago

Incompatibility between IRCd and user. Apparently, this function is supposed to read packets from IRCds following the RFC 1459 and not updated since then. A line was apparently misread and caused a crash when trying to use a not found expression in it. I added an error message providing a value for this, on both actual and old irc versions. https://github.com/Ombridride/minetest-minetestforfun-server/commit/582f7a363509f6c6684c5f607cc3ecc64f1027a0

BetterToAutomateTheWorld commented 9 years ago

Ok, i will see the return for next reboot

BetterToAutomateTheWorld commented 9 years ago

The next reboot was OK, i closed the issue