search

MingYSub / SubsArchive

Subs by MingYSub
56 stars 4 forks source link

Some links in Subtitle Overview are invalid #12

Closed 3gf8jv4dv closed 3 months ago

3gf8jv4dv commented 3 months ago
Invalid Link Correct Link
https://raw.githubusercontent.com/MingYSub/SubsArchive/main/Archive/Hokkyoku%20Hyakkaten%20no%20Concierge-san https://github.com/MingYSub/SubsArchive/tree/main/Archive/Hokkyoku%20Hyakkaten%20no%20Concierge-san
https://raw.githubusercontent.com/MingYSub/SubsArchive/main/Archive/Senpai%20wa%20Otokonoko https://github.com/MingYSub/SubsArchive/tree/main/Archive/Senpai%20wa%20Otokonoko
https://github.com/MingYSub/SubsArchive/tree/main/Archive/Do%20It%20Yourself https://github.com/MingYSub/SubsArchive/tree/main/Archive/Do%20It%20Yourself%21%21
https://github.com/MingYSub/SubsArchive/tree/main/Archive/Bocchi%20the%20Rock https://github.com/MingYSub/SubsArchive/tree/main/Archive/Bocchi%20the%20Rock%21

By the way. Among the remaining GitHub links, some include blob and some include tree. Could we use the latter uniformly? Because GitHub will automatically redirect to a link containing the latter when accessing a link containing the former.

MingYSub commented 3 months ago

Thanks for reporting. All links have been corrected.

3gf8jv4dv commented 3 months ago

Two links have errors.

Invalid Link Correct Link
https://github.com/MingYSub/SubsArchive/tree/main/Archive/Kono%20Subarashii%20Sekai%20ni%20Bakuen%20wo! https://github.com/MingYSub/SubsArchive/tree/main/Archive/Kono%20Subarashii%20Sekai%20ni%20Bakuen%20wo%21
https://github.com/MingYSub/SubsArchive/tree/main/Archive/Onii-chan%20wa%20Oshimai! https://github.com/MingYSub/SubsArchive/tree/main/Archive/Onii-chan%20wa%20Oshimai%21

This is a troublesome question. The ! will not be converted to %21 when copying the link as URL, however GitHub Projects will only recognize the latter. This happened to our fellow industry player KitaujiSub.

MingYSub commented 3 months ago

This is a troublesome question. The ! will not be converted to %21 when copying the link as URL, however GitHub Projects will only recognize the latter. This happened to our fellow industry player KitaujiSub.

Fixed. Still, for new animes, we will consider using abbreviations (if there are official ones) and also avoid special characters like ?!:.,.

3gf8jv4dv commented 3 months ago

for new animes, we will consider using abbreviations (if there are official ones) and also avoid special characters like ?!:.,.

That is exactly what I want to say :)

3gf8jv4dv commented 3 months ago

Ah, I also noticed that after clicking an item on the left in the Subtitle Overview, there is a link in the page that appears. That one looks like it should be revised as well.