search

MingweiSamuel / Camille

C# Riot API Library. Thread safe, automatic retries, autogenerated nightly releases.
Other
102 stars 8 forks source link

Camille nightlies aren't published to NuGet #32

Open aPinat opened 4 years ago

aPinat commented 4 years ago

Camille.Enums for example is still missing new champions like Aphelios or Sett in the latest nightly release on NuGet. CI still seams to be building nightly versions, but not deploying them when there are changes.

MingweiSamuel commented 4 years ago

Thanks for the report, I'll take a look today

MingweiSamuel commented 4 years ago

Looks like I made a logical error in the build script, and also the deploy key expired. Fixed

Thanks for the report, let me know if there are any other issues

aPinat commented 3 years ago

Currently the detection of changes seams to be broken again, as both the gh-pages branch and the newest NuGet nightly do not have Seraphine as new champion.

aPinat commented 3 years ago

@MingweiSamuel Could you trigger a new build to add MingweiSamuel/riotapi-schema#26?

MingweiSamuel commented 3 years ago

Done. I set it up to trigger on enum updates although it still won't catch new champions if all else stays the same

aPinat commented 3 years ago

But it didn't catch the ULTBOOK addition in the GameMode enum, and since you merged it 3 days ago it should've updated at some point in between then and your manual trigger, or am I understanding wrong?

MingweiSamuel commented 3 years ago

I just changed it to account for enum updates yesterday. Latest nightly has what you expect, right?

aPinat commented 3 years ago

Ohhh I see. Yes absolutely, thanks!