search

MingweiSamuel / Camille

C# Riot API Library. Thread safe, automatic retries, autogenerated nightly releases.
Other
102 stars 8 forks source link

Summoner.Puuid in SummonerV4 API Breaks Naming Convention #95

Closed ElizabethDownum closed 1 year ago

ElizabethDownum commented 1 year ago

image

All other variables are appended with "Id", whereas for puuid, it is "id".

Slightly confusing is all, very minor issue.

MingweiSamuel commented 1 year ago

With Camille I'm choosing to derive the names directly from the Riot API. In the JSON the "id" is also not capitalized in puuid.

SummonerDTO
- represents a summoner
Name | Data Type | Description -- | -- | -- accountId | string | Encrypted account ID. Max length 56 characters. profileIconId | int | ID of the summoner icon associated with the summoner. revisionDate | long | Date summoner was last modified specified as epoch milliseconds. The following events will update this timestamp: summoner name change, summoner level change, or profile icon change. name | string | Summoner name. id | string | Encrypted summoner ID. Max length 63 characters. puuid | string | Encrypted PUUID. Exact length of 78 characters. summonerLevel | long | Summoner level associated with the summoner.