MingweiSamuel / riotapi-schema

OpenAPI/Swagger Schema of the Riot Games API
http://www.mingweisamuel.com/riotapi-schema/tool/
41 stars 9 forks source link

Remove swagger-ui submodule in favor of package #25

Closed themaxdavitt closed 3 years ago

themaxdavitt commented 3 years ago

The swagger-ui submodule being used is huge.

$ git clone --recursive https://github.com/MingweiSamuel/riotapi-schema
Cloning into 'riotapi-schema'...
remote: Enumerating objects: 210, done.
remote: Counting objects: 100% (210/210), done.
remote: Compressing objects: 100% (83/83), done.
remote: Total 2904 (delta 152), reused 172 (delta 127), pack-reused 2694
Receiving objects: 100% (2904/2904), 6.70 MiB | 4.87 MiB/s, done.
Resolving deltas: 100% (2025/2025), done.
Submodule 'swagger-ui' (https://github.com/swagger-api/swagger-ui.git) registered for path 'swagger-ui'
Cloning into '/home/user/Projects/riotapi-schema/swagger-ui'...
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 30781 (delta 10), reused 1 (delta 0), pack-reused 30758
Receiving objects: 100% (30781/30781), 324.38 MiB | 4.68 MiB/s, done.
Resolving deltas: 100% (18809/18809), done.
Submodule path 'swagger-ui': checked out 'b91eb3099eabb5b9c35f482b4bb6afd7fee114f6'

I swapped it out for the swagger-ui-dist package that exports the files we were pulling from it. Much more space efficient.

MingweiSamuel commented 3 years ago

Very nice, thanks!