search

MingweiSamuel / riotapi-schema

OpenAPI/Swagger Schema of the Riot Games API
http://www.mingweisamuel.com/riotapi-schema/tool/
41 stars 8 forks source link

Double `queueId` in `tft-match-v1.InfoDto` #52

Closed renja-g closed 5 months ago

renja-g commented 5 months ago

Is it right that queueId is declared two times in the schema? One is queueId and the other queue_id. and one is optional and the other is not.

    tft-match-v1.InfoDto:
      type: object
      title: InfoDto
      properties:
        tft_game_type:
          type: string
          x-type: string
        tft_set_core_name:
          type: string
          x-type: string
        game_datetime:
          type: integer
          format: int64
          x-type: long
          description: 'Unix timestamp.'
        game_length:
          type: number
          format: float
          x-type: float
          description: 'Game length in seconds.'
        game_variation:
          type: string
          x-type: string
          description: 'Game variation key. Game variations documented in TFT static data.'
        game_version:
          type: string
          x-type: string
          description: 'Game client version.'
        participants:
          type: array
          items:
            $ref: '#/components/schemas/tft-match-v1.ParticipantDto'
            x-type: ParticipantDto
          x-type: 'List[ParticipantDto]'
+       queue_id:
          type: integer
          format: int32
          x-type: int
          description: 'Please refer to the League of Legends documentation.'
          x-enum: queue
        tft_set_number:
          type: integer
          format: int32
          x-type: int
          description: 'Teamfight Tactics set number.'
        endOfGameResult:
          type: string
        gameCreation:
          type: integer
          format: int64
        gameId:
          type: integer
          format: int64
        mapId:
          type: integer
          format: int64
+       queueId:
          type: integer
          format: int32
          x-type: int
          description: 'Please refer to the League of Legends documentation.'
          x-enum: queue
      required:
        - game_datetime
        - game_length
        - game_version
        - participants
        - queue_id
        - tft_set_number
MingweiSamuel commented 5 months ago

It is unfortunately accurate, lol https://github.com/RiotGames/developer-relations/issues/749#issuecomment-1995907878 image

renja-g commented 5 months ago

Ohh wow, ok sorry for not looking through the closed issues

MingweiSamuel commented 5 months ago

Yup no worries, got a whole slew of backed up issues in https://github.com/RiotGames/developer-relations/issues/created_by/mingweisamuel