search

MingweiSamuel / riotapi-schema

OpenAPI/Swagger Schema of the Riot Games API
http://www.mingweisamuel.com/riotapi-schema/tool/
41 stars 9 forks source link

Missing regional proxies used by tournament API #6

Closed Derpthemeus closed 5 years ago

Derpthemeus commented 5 years ago

The tournament API uses the host americas.api.riotgames.com, which is not listed in the available platforms.

Reference: https://developer.riotgames.com/regional-endpoints.html

MingweiSamuel commented 5 years ago

Alright, should be an easy fix to add, taking a look now

MingweiSamuel commented 5 years ago

I'm considering adding

servers = [{
    url: 'https://americas.api.riotgames.com'
}]

(or similar) to each of the tournament endpoints which would override the default server platforms. Botty would need to be updated to check this field I assume

MingweiSamuel commented 5 years ago

I decided not to take this route and add them all to the global server variables. there's now a x-platforms-available field to show which endpoints are available per method

so this should be working for botty as soon as everything updates

MingweiSamuel commented 5 years ago

Note that this means botty will parse incorrect requests going to americas.api.riotgames.com for other endpoints (for now)