search

MinhThienDX / win10widgets

A fork from https://github.com/tjmarkham/win10widgets
MIT License
49 stars 11 forks source link

Merged the Weather (Multilanguage) Patch from Eclectic-Tech #11

Closed Kablion closed 5 years ago

Kablion commented 5 years ago

Source: https://www.deviantart.com/eclectic-tech/art/Win10-Weather-Multilingual-780571988

I mainly just a copied the files downloaded from there. I did adjust/fix a few things like the language support, theme support...

MinhThienDX commented 5 years ago

Can you take a look at this https://www.deviantart.com/eclectic-tech/art/Win10-Weather-Patch-V2-0-1-780236969 I wonder if there is any different (not about translation) between 2 versions 🤔 I have asked for permission and he replied "Yes. You have permission to use in your fork of Win10 Widgets with attribution to this patch." 😍 Did you ask him for permission about the Multilanguage version?

Kablion commented 5 years ago

I wonder if there is any different (not about translation) between 2 versions 🤔

The main differences besides the translation are some Meter size and position changes to fit better for every language. There is also a little difference in getting the right weather icon but it seems to work either way.

Did you ask him for permission about the Multilanguage version?

Now I did ;) and he gave it to me: "Yeah, no problem. Just that I would appreciate if you let me know if you make any modifications to it." And I also did tell him my modifications. :)