search

MiniCodeMonkey / amazon-alexa-php

Amazon Alexa PHP Library
99 stars 70 forks source link

Merge a fork? #1

Open jakubsuchy opened 8 years ago

jakubsuchy commented 8 years ago

The fork by @kora88 currently has all the necessary validation tools, could it be merged here so users don't discover an incomplete toolkit via Composer?

MiniCodeMonkey commented 8 years ago

It would be great to merge that!

danstreeter commented 7 years ago

Agreed - there are a lot of forked upstream fixes that fix some vital things. I'm using this library for a custom skill i'm working on - so might fork and merge all fixes in as one hit to get me going.

emerham commented 7 years ago

Looking at the forks and history of each one, @froodley https://github.com/froodley/amazon-alexa-php/network has done a lot of work with code. Edit I see now that froodley has identified it is a breaking change from the initial repo and it will no longer work as a possible merge, but there are some good things to possibly add back in. I was trying to get slots working with an app and see that some of the code they added to the Intent class helps in getting some of the data from the request.