search

MiniDigger / MiniMappingViewer

Mini's Mapping Viewer
https://minidigger.github.io/MiniMappingViewer
MIT License
66 stars 5 forks source link

Add 1.17 mappings #94

Open TobiasDeBruijn opened 3 years ago

TobiasDeBruijn commented 3 years ago

Hey there,

When opening the Mojang->Spigot mappings for 1.17, Error while loading spigot mappings: Version not found is thrown.

However content is displayed, but I don't know how up-to-date this is, or if it is correct. The 'Spigot Name' field is empty.

TobiasDeBruijn commented 3 years ago

Note also that some classes, e.g net.minecraft.network.protocol.game.PacketPlayOutPosition don't show up in search results.

MiniDigger commented 3 years ago

there is way more stuff to do, as spigot partly uses mojang mappings now.

and since paper will be moving to mojang mappings, quite frankly, am not sure if updating it is worth it, everbody should code against mojang mappings.

ill still leave this open just in case

TobiasDeBruijn commented 3 years ago

I suppose it might be best to leave the spigot names empty, since as you mentioned people should now be using mojang mappings.

However, I do think it's important to update the mappings, even just to get the mappings between mojang (sensible) names and their obfuscated counterparts, it's darn useful information for people (like me) using reflection :D

andrew121410 commented 3 years ago

I'm not sure on how to make a pull request for glist's aka(builddata.json) also this might not be correct I think it is though

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-cl.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-members.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

MiniDigger commented 3 years ago

changing the gist is not enough, the code itself needs to be fixed. 1.16.5 is already broken