MiniGlome / Archive.org-Downloader

Python3 script to download archive.org books in PDF format
865 stars 116 forks source link

does this work on m1 macs? #86

Closed mxradio closed 1 year ago

mxradio commented 1 year ago

Program works fine on my intel mac. I get this error on silicon mac:

src/core/annotation.cpp:4:10: fatal error: 'qpdf/Constants.h' file not found

include <qpdf/Constants.h>

           ^~~~~~~~~~~~~~~~~~
  src/core/nametree.cpp:4:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  src/core/numbertree.cpp:4:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  src/core/embeddedfiles.cpp:4:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  src/core/object.cpp:7:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  In file included from src/core/logger.cpp:4:
  src/core/pikepdf.h:10:10: fatal error: 'qpdf/QPDF.hh' file not found
  #include <qpdf/QPDF.hh>
           ^~~~~~~~~~~~~~
  src/core/object_convert.cpp:12:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  src/core/job.cpp:6:10: fatal error: 'qpdf/QPDFJob.hh' file not found
  #include <qpdf/QPDFJob.hh>
           ^~~~~~~~~~~~~~~~~
  src/core/object_repr.cpp:19:10: fatal error: 'qpdf/Constants.h' file not found
  #include <qpdf/Constants.h>
           ^~~~~~~~~~~~~~~~~~
  In file included from src/core/page.cpp:9:
  src/core/pikepdf.h:10:10: fatal error: 'qpdf/QPDF.hh' file not found
  #include <qpdf/QPDF.hh>
           ^~~~~~~~~~~~~~

note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for pikepdf Failed to build pikepdf ERROR: Could not build wheels for pikepdf, which is required to install pyproject.toml-based projects

sveinbjornpalsson commented 1 year ago

Same.

sveinbjornpalsson commented 1 year ago

I went to the pikepdf repo, found these instructions:

gsvr commented on Apr 3 I've encountered the same issue on Apple M1. This was resolved by first running brew install qpdf before installing via pip (pip install pikepdf) I suggest just adding a line to the docs that for Apple Silicon you might need to first install qpdf via brew install.

I tried it, seems to work.

mxradio commented 1 year ago

@sveinbjornpalsson Thanks very much, works for me too.

MiniGlome commented 1 year ago

This issue seems to be fixed

I am going to close this now. Prior to pikepdf 8.0, I was building Apple Silicon manually on a laptop. It's now automated on Cirrus CI, so the build process should be much more stable. Originally posted by @jbarlow83 in https://github.com/pikepdf/pikepdf/issues/453#issuecomment-1636408425