search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.73k stars 407 forks source link

adding rubocop-discourse and fixing Style/RedundantReturn offenses #421

Closed jethroo closed 4 years ago

jethroo commented 4 years ago

The rubocop.yml referres to the one of https://github.com/discourse/discourse (not sure why though).

But with this commit: https://github.com/discourse/discourse/commit/eaf6096890120906b4f4e6282eb399afc5039559#diff-11a0d7906801d9dea0eccb85667ad811 the new dependency to rubocop-discourse was introduced with custom cops.

This PR adds the new dependency and also fixes the "new" offenses of type Style/RedundantReturn

codecov-io commented 4 years ago

Codecov Report

Merging #421 into master will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          21       21           
  Lines        1247     1247           
=======================================
  Hits         1101     1101           
  Misses        146      146
Impacted Files Coverage Δ
lib/patches/sql_patches.rb 75.6% <0%> (ø) :arrow_up:
lib/mini_profiler/gc_profiler.rb 96.42% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7ddce2...7f36c51. Read the comment docs.

SamSaffron commented 4 years ago

great change :+1: thanks!!