search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.7k stars 403 forks source link

Regression: client_timings UI, that contained 'show trivial' link, disappeared when upgrading from 1.0.2 to 1.1.6 #440

Closed feliperaul closed 4 years ago

feliperaul commented 4 years ago

Before the upgrade, on v. 1.02, I had this section in my profile that allowed me, amongst other details, to click 'show trivial':

image

That square in the picture is a <div class="profiler-timings profiler-client-timings">.

However, after the upgrade to 1.1.6, that whole area disappeared:

image

Even setting Rack::MiniProfiler.config.show_trivial = true doesn't show it back.

SamSaffron commented 4 years ago

Confirmed ... this has gone missing @OsamaSayegh can you have a look?

SamSaffron commented 4 years ago

Note ... while looking at this... timing client side have gotten better over the years, there may be some improvements lurking.

feliperaul commented 4 years ago

@SamSaffron @OsamaSayegh I wanted to point out that the results in the latest version already include the trivial steps in the resulting HTML, but they are hidden by a display: none CSS, and there's no link anywhere to be seen to toggle them visible (as there was in the 1.0.2 version).

If I manually disable that CSS rule I get the result I'm looking for (the trivial steps show up).

image

OsamaSayegh commented 4 years ago

OK, thanks for reporting this @feliperaul. https://github.com/MiniProfiler/rack-mini-profiler/pull/441 should bring back client timings and the show trivial button. I've included a screenshot in the PR. Let me know if there is anything else missing.

OsamaSayegh commented 4 years ago

FYI @feliperaul version 2.0.2 is out with this fix 🎉 Thanks for your report!

feliperaul commented 4 years ago

Thank you @OsamaSayegh and @SamSaffron !