Closed OsamaSayegh closed 3 years ago
Merging #475 (acd6bfe) into master (f9a991b) will decrease coverage by
0.20%
. The diff coverage is18.18%
.
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 87.89% 87.69% -0.21%
==========================================
Files 18 18
Lines 1239 1243 +4
==========================================
+ Hits 1089 1090 +1
- Misses 150 153 +3
Impacted Files | Coverage Δ | |
---|---|---|
lib/mini_profiler/profiler.rb | 85.14% <18.18%> (-0.54%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f9a991b...acd6bfe. Read the comment docs.
Looks great to me :confetti_ball:
Let's add a rake task to update us to latest speedscope rake update:speedscope
that way we can get upstream fixes easily.
Hi! I'm the author of speedscope and just wanted to say that this is awesome! I made an opinionated fork of rack-mini-profiler in the past to do this (https://github.com/jlfwong/rack-mini-profiler), but so happy this is in rack-mini-profiler
core now!
Hi Jamie, huge fan! Thanks so much for building speedscope
On Fri, 15 Jan 2021 at 8:40 pm, Jamie Wong notifications@github.com wrote:
Hi! I'm the author of speedscope and just wanted to say that this is awesome! I made an opinionated fork of rack-mini-profiler in the past to do this (https://github.com/jlfwong/rack-mini-profiler), but so happy this is in rack-mini-profiler core now!
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/MiniProfiler/rack-mini-profiler/pull/475#issuecomment-760784907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABIXPXNV7HEUOSHK24IZLS2AEPNANCNFSM4VI2PY5Q .
Mini Profiler now ships with an embedded copy of speedscope which provides a very nice experience for viewing flamegraphs.
Flamegraph has been replaced with the stackprof gem. It's an optional dependency, so if you use the flamegraphs feature, you'll need to add the
stackprof
gem to yourGemfile
and require it. If you don't use the feature, you don't need to add anything and Mini Profiler will work just fine.