search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.7k stars 402 forks source link

Add support for adding CSP nonce to profile handler JS script tag #495

Closed richhollis closed 3 years ago

SamSaffron commented 3 years ago

I think we need a bit more here, can you add a readme that explains this, also it looks like the only way to configure this is via env, I think it is better if you can configure this via rack mini profiler settings (and have that win), mini profiler is often first in the rack middleware stack so it will not be able to get information from rails.

richhollis commented 3 years ago

Hi @SamSaffron

I've just pushed some revisions. Please take a look and let me know if this aligns with what you're thinking. If you need anything else then just let me know.

Cheers

SamSaffron commented 3 years ago

looks great to me! thanks :confetti_ball:

richhollis commented 3 years ago

Great! :+1: This should close #439.