Remove type attribute from includes script

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.

MIT License

3.7k stars 402 forks source link

Remove type attribute from includes script #500

Closed lukel97 closed 3 years ago

lukel97 commented 3 years ago

In HTML 5, the default since rails 3, the type attribute on scripts defaults to "text/javascript". Removing this fixes warnings being thrown by HTML 5 validators that complain "The type attribute is unnecessary for JavaScript resources", specifically the W3 validator

SamSaffron commented 3 years ago

I am not sure about this, I support some opt-out I guess, but non HTML 5 still needs this.

lukel97 commented 3 years ago

Understandable, wasn't sure if HTML4 was still supported or not