search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.7k stars 402 forks source link

Add flamegraph_mode config option and query string parameter #508

Closed evanleck closed 3 years ago

evanleck commented 3 years ago

With this change, the :mode passed to StackProf.run can be customized just like the sample rate.

SamSaffron commented 3 years ago

This looks great to me, can you also add a note to the README here?

@OsamaSayegh can you double check?

codecov-commenter commented 3 years ago

Codecov Report

Merging #508 (43c0e9c) into master (3f47ae9) will decrease coverage by 0.26%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   87.51%   87.25%   -0.27%     
==========================================
  Files          18       18              
  Lines        1258     1263       +5     
==========================================
+ Hits         1101     1102       +1     
- Misses        157      161       +4
Impacted Files Coverage Δ
lib/mini_profiler/profiler.rb 83.19% <0.00%> (-0.72%) :arrow_down:
lib/mini_profiler/config.rb 88.15% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f47ae9...43c0e9c. Read the comment docs.

evanleck commented 3 years ago

@SamSaffron @OsamaSayegh my pleasure! I've added a note to the README as requested :)