search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.71k stars 404 forks source link

Deprecate rack_profiler:install in favour of rack_mini_profiler:install #550

Closed gmcgibbon closed 1 year ago

gmcgibbon commented 1 year ago

The gem's name and install generator should be the same.

This deprecates the current generator in favour of a more appropriately named one. It also updates copy on the initializer comments and usage clarifying what it is doing and when to use an initializer. Behaviour is changed for the install generator to always generate a rack_mini_profiler.rb initializer instead, but I think that's acceptable if we want to rename the generator.

codecov-commenter commented 1 year ago

Codecov Report

Merging #550 (dd4e83b) into master (edbcad3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head dd4e83b differs from pull request most recent head 8cea50f. Consider uploading reports for the commit 8cea50f to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files          18       18           
  Lines        1269     1269           
=======================================
  Hits         1109     1109           
  Misses        160      160

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SamSaffron commented 1 year ago

I think the reason I was holding off on merging stuff was cause our test suite is not passing, looks unrelated though.