search

MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.71k stars 404 forks source link

Add titles to middleware pages #552

Closed gmcgibbon closed 1 year ago

gmcgibbon commented 1 year ago

Right now the pages you visit that route to the middleware don't have HTML titles or valid markup. This fixes that.

codecov-commenter commented 1 year ago

Codecov Report

Merging #552 (55e2a34) into master (edbcad3) will increase coverage by 0.78%. The diff coverage is 100.00%.

:exclamation: Current head 55e2a34 differs from pull request most recent head af5d27a. Consider uploading reports for the commit af5d27a to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   87.39%   88.17%   +0.78%     
==========================================
  Files          18       18              
  Lines        1269     1269              
==========================================
+ Hits         1109     1119      +10     
+ Misses        160      150      -10
Impacted Files Coverage Δ
lib/mini_profiler/profiler.rb 85.41% <100.00%> (+1.90%) :arrow_up:
lib/mini_profiler/client_settings.rb 95.58% <0.00%> (+1.47%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nateberkopec commented 1 year ago

Rebase and LGTM 👍