MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.71k stars 404 forks source link

Validate our responses with Rack::Lint in tests #563

Open nateberkopec opened 1 year ago

nateberkopec commented 1 year ago

https://github.com/rack/rack/blob/main/lib/rack/lint.rb

In tests

keshavbiswa commented 1 year ago

Not sure where to add this.

keshavbiswa commented 1 year ago

Does something like this work?

          # Validate using Rack::Lint
          if config.rack_lint_enabled # rack_lint_enabled is set to true by default
            status, headers, body = Rack::Lint.new(@app).call(env)
          else
            status, headers, body = @app.call(env)
          end

@nateberkopec

nateberkopec commented 1 year ago

Ah sorry - I should've been more specific. This should only be added to our test suite.