Incorrect energy loss in doppler mode 3

[warr]

In MiniballReaction::IdentifyEjectile and MiniballReaction::IdentifyRecoil for doppler_mode > 2, the code calculates v/c for the particle emitting the gamma ray using the energy detected in the CD, which is corrected for the energy loss in the dead layer of the CD and also corrected for the energy loss in the target after the interaction point (though it does not consider that the particle is going through the target at an angle). This yields the v/c at the interaction point. However, unless the lifetime is very short, the gamma will really be emitted after the particle has left the target, so we want that v/c not the one at the interaction point. So I don't think we want the corrections on lines 787 and 842.

[lpgaff]

Thanks for this. Indeed this was discussed previously and there was a hacked version floating around at one point that ignored this extra energy loss and it used doppler_mode = 4. Maybe we simply need to document all these possible options properly and make sure that the code is consistent with the documentation. That way, the user can decide to include certain effects or not as they wish?

[warr]

This code is inside a if (dopppler_mode > 2) {} so it will also apply to doppler_mode 4. Or are you referring to a different version from this one?

[lpgaff]

I am saying that this was discussed previously and somebody introduced a new doppler mode to handle the situation. Doppler mode 4 does not exist in the main code. It was in a hacked version of the code that was never submitted for merger in to the main code. That is why you can still see the problem