search

MinicraftPlus / minicraft-plus-revived

Minicraft+, an extension of Notch's original minicraft project, with tons more features.
GNU General Public License v3.0
484 stars 97 forks source link

Changing all .wav sound files into .ogg #433

Open BenCheung0422 opened 1 year ago

BenCheung0422 commented 1 year ago

Is your feature request related to a problem? Please describe. .ogg is the smallest sound file format among the common sound file formats, and .wav is always large in file size. Usually, the compressed formats are used in the final productions. Unless we are doing the original sound sources, we could use .wav. Otherwise, the compressed formats should be used. Reference.

Describe the solution you'd like Removing all .wav supports in the game but changing all sound file formats into .ogg supports.

Makkkkus commented 1 year ago

I agree with this.

BenCheung0422 commented 1 year ago

We might use FLAC OGG over OPUS OGG. Also, https://www.tagtraum.com/ffsampledsp/index.html could have good suit to the current resource system.

BenCheung0422 commented 2 months ago

Since OGG is just a container, it can use various codecs, we can support multiple codecs here for the creators to choose. However, since by convention and etc., there are suggested extensions when using them, like .opus for OPUS. Therefore, we can support both Vorbis, OPUS and FLAC (though there exists simple container format for FLAC) with OGG container (others are left unsupported), and include both .ogg, .opus and .flac as the identifying extensions. Practically, it is suggested to use .opus for OPUS, and so on. Though .ogg would be compatible wit all these 3 codecs, the other 2 would just expect their corresponding codecs or else a warning/exception should be emitted. Unless someone thinks it is "complicated" to allow the other 2 extensions, this is the suggestion.

.wav is suggested to still be supported for backward compatibility.