MinicraftPlus / minicraft-plus-revived

Minicraft+, an extension of Notch's original minicraft project, with tons more features.
GNU General Public License v3.0
477 stars 96 forks source link

Remove the removal for empty values in saves #565

Closed BenCheung0422 closed 11 months ago

BenCheung0422 commented 1 year ago

This would fix #564. This is a further fix for #519. As the preferences may contain empty values, if the preferences contain empty values, unexpected errors may occur due to the original design based on values "as is" (without empty string removals). Bypassing this problem in 2.2.0-dev3, users can first launch versions before 2.2.0-dev3 to generate JSON format preferences without this kind of error (as mentioned in https://github.com/MinicraftPlus/minicraft-plus-revived/pull/519#issuecomment-1694990750).

Note that if players have already been using 2.2.0-dev3 or 2.2.0-dev2 updating their preferences, the preferences settings might have already been broken.