MinicraftPlus / minicraft-plus-revived

Minicraft+, an extension of Notch's original minicraft project, with tons more features.
GNU General Public License v3.0
466 stars 93 forks source link

Improved supports for in-app/game notifications and toasts #587

Open BenCheung0422 opened 9 months ago

BenCheung0422 commented 9 months ago

This feature is reserved for future use. This adds a support for in-app notifications, where toasts in the screen. It is different from in-game notifications, bare text only, as this includes a frame, and the color can be changed. This is important when there are some alerts, warnings and important information needed to notify the users.

I have several ideas about box popups and notifications: (fading is not supported right now)

Position for toasts may be configurable to upper or lower positions (also for each type of toast notification?).

Additionally, achievement unlocking toast is added to replace the text-only notifications regarding unlocking achievements. (https://discord.com/channels/280723930942013440/1141498209634623539) This improves visual quality of life.

BenCheung0422 commented 8 months ago

Demo from #588:

https://github.com/MinicraftPlus/minicraft-plus-revived/assets/74168521/7ab7db55-08c4-4b11-9350-6389841eaf20

Makkkkus commented 8 months ago

In-app notifications are usually a result of bad game design. Using this will make the game feel more like a cheap mobile game than an free and open-source sandbox game. Perhaps an icon can be showed insted when a controller is plugged in?

BenCheung0422 commented 7 months ago

New design for toast notifications

https://github.com/MinicraftPlus/minicraft-plus-revived/assets/74168521/cffae65d-cf92-43c4-a21b-8d1d4f0639bb

BenCheung0422 commented 7 months ago

App status top bar (shows automatically for 2 seconds on startup and shown when "9" (I was seeking to use symbols but it seems like they are not supported, which is not rightActually it is possible, but with different wordings) is down)

https://github.com/MinicraftPlus/minicraft-plus-revived/assets/74168521/2cc64d21-6f8a-4a49-a951-201d10ba73d9

BenCheung0422 commented 7 months ago

The new achievement unlocking toast, replacing the original text-only notification.

https://github.com/MinicraftPlus/minicraft-plus-revived/assets/74168521/fb76d0cd-5d00-423b-8021-1d7c6e647dfd

BenCheung0422 commented 7 months ago

Updates has been made for this pull request regarding the issues and it is now ready for review again.

BenCheung0422 commented 6 months ago

Ok, it is removed.

Litorom commented 2 months ago

Can you update this please.

BenCheung0422 commented 2 months ago

Okay, branch updated.