search

MinicraftPlus / minicraft-plus-revived

Minicraft+, an extension of Notch's original minicraft project, with tons more features.
GNU General Public License v3.0
456 stars 92 forks source link

FPS dropping near lava #672

Closed Tokarif closed 1 month ago

Tokarif commented 2 months ago

Describe the bug When I approach lava my FPS are dropping drastically until game is almost unplayable.

To Reproduce Steps to reproduce the behavior:

  1. Go to a lava lake
  2. See fps dropping

Expected behavior Lava should behave like water... or any other tile. :-)

Screenshots

Lava level on the border of the map 42 FPS Capture d'écran 2024-05-01 011305

Same world, same level, but in the middle of the lava lake : 5 FPS Capture d'écran 2024-05-01 011343

Desktop (please complete the following information):

Additional context The problem ocurs on all of my worlds.

Litorom commented 2 months ago

It would appear that this bug was fixed for Water tiles but someone forgot to fix Lava tiles too

BenCheung0422 commented 2 months ago

After my testing, I spotted out that the issue is related to light rendering.

BenCheung0422 commented 2 months ago

The number of lighting circles can go over 700, so it is a quite tricky issue to resolve.