search

Minifixio / pocketmine-1vs1-plugin

1vs1 pocketmine plugin for Minecraft Pocket Edition
Apache License 2.0
18 stars 38 forks source link

Updated ArenaManagaer.php #17

Closed applqpak closed 8 years ago

applqpak commented 8 years ago

Multiple Bad Practises. I've fixed most. Please work on this, otherwise, nice plugin!

robske110 commented 8 years ago

Why isn't that merged yet? It is an MUST

Minifixio commented 8 years ago

I didn't try but I trust him.

robske110 commented 8 years ago

I will test this this evening!

Minifixio commented 8 years ago

It will not work as the getServer() method is not referenced in to the ArenaManager class ? Did someone test it ?

robske110 commented 8 years ago

use pocketmine\server?

robske110 commented 8 years ago

And can you please check my pull request out?

robske110 commented 8 years ago

REVERT THID NOT WORKING

robske110 commented 8 years ago

He can pass the object via constructor

robske110 commented 8 years ago

image This is the shortest way to do it (i think lol)

robske110 commented 8 years ago

Now