Minimalistic-Apps / price-converter

Minimalistic price converter that allows you to convert prices of fiat shitcoins easily. It uses Bitcoin as the base currency.
MIT License
15 stars 2 forks source link

Re-implement more currencies #60

Closed BloodRaven0 closed 2 years ago

BloodRaven0 commented 2 years ago

The recent update removed some currencies, including BGN, that I used on the older version, which is why I downgraded back to it.

hank-milliken commented 2 years ago

Hi, thank you very much for you feedback. Sorry for this regression. This issue is covered by #41 and it is because the only currently working provider Coingecko is missing some currencies.

The desired state is to have all 3 providers back and do an average of their rates.

I will make this priority and I hopefully fix it soon.

hank-milliken commented 2 years ago

The PR #62 solves your Issue + much more ;)

I need to add one more provider before I merge it. But if you are able to build and run the code, I will be happy if you can test it. ;)

signal-2022-08-22-031314

signal-2022-08-22-031305

BloodRaven0 commented 2 years ago

@hank-milliken That's awesome! Sadly I'm not tech-savvy enough to build it on my own, so I'll just wait for the update on F-Droid.

hank-milliken commented 2 years ago

@BloodRaven0 Merged, you can download build directly from Github here https://github.com/Minimalistic-Apps/price-converter/releases/tag/2.5.0

:exclamation: But make sure you uninstall it before you download it from F-Droid. Github build is signed by my key, the build from F-Droid is signed by them and it is not possible to upgrade apps with mismatching keys.