search

MinimallyCorrect / ModPatcher

Allows easy patching of mods/plugins/arbitrary minecraft classes using config files
MIT License
8 stars 6 forks source link

No lib download? #15

Closed Sir-Will closed 7 years ago

Sir-Will commented 7 years ago

hey, is there a reason that there is no longer a lib download which includes the dependencies?

LunNova commented 7 years ago

Dependencies are now intended to be bundled/downloaded using LibLoader.

See TickProfiler's build.gradle for how this is set up: https://github.com/MinimallyCorrect/TickProfiler/blob/1.12/build.gradle

ModPatcher should have a separate download which allows it to be used on its own instead of as a library, but I forgot to do that. #16.

Sir-Will commented 7 years ago

I'm using both but somehow the latest build doesn't create the ModPatcher dir and log file so I thought the dependencies were misisng.

Sir-Will commented 7 years ago

Any news to this issue? I would really like to use the latest TickProfiler and ModPatcher version.

LunNova commented 7 years ago

Put tickprofiler in your mods folder. Problem solved?

There is no separate lib download but that won't stop you using it.

Sir-Will commented 7 years ago

I did that, the issue is that it doesn't create the ModPatches directory and doesn't load any patches while there are no errors in the log.

LunNova commented 7 years ago

It should still load patches from /ModPatches. Upload your fml log please?

Sir-Will commented 7 years ago

https://gist.github.com/Sir-Will/4db84e8e4d3f8850f818396b6612af1a

LunNova commented 7 years ago

Can you remove the ModPatcher jar from your mods folder, then update TickProfiler to build 59?

It looks like three patches were loaded, but due to a bug the debug output is not as good as it should be.

https://gist.github.com/Sir-Will/4db84e8e4d3f8850f818396b6612af1a#file-gistfile1-txt-L120

There aren't any later errors, but only two classes get patched. Possibly the class you're patching either doesn't match the name of any class which actually gets loaded, or that class is in the classloader transformer exclusion list and can't be patched.

The new build fixes the debug logging there so if you run with it and post the log it should include some more information.

Sir-Will commented 7 years ago

Hm, so ModPatcher is in TickProfiler included now? I didn't add any patches yet, the 3 patches are the ones from TickProfiler I think.

I just added a patch and now it shows 4. Will test in a moment if the patch worked.

Sir-Will commented 7 years ago

Seems to work.

What confused me is that it no longer creates the ModPatches directory and the ModPatcher.log and I couldn't check for errors patch errors because of that, that's why I thought it was broken.

Any chance to get the ModPatcher.log file back? Makes it much easier to find and read the errors.

LunNova commented 7 years ago

Good to hear that it's still working :)

There will eventually be a separate standalone ModPatcher download again with the same logging behaviour and automatic creation of the ModPatches folder.

Tracking that issue under #16.