MinimallyCorrect / TickThreading

Historical multi-threaded minecraft by @LunNova. Performance over correctness. What could go wrong? Way too much.
https://jenkins.nallar.me/job/TickThreading/
MIT License
143 stars 43 forks source link

Using Mixins #1251

Closed gabizou closed 8 years ago

gabizou commented 8 years ago

So I've noticed that there's something called Mixin and while it's great and all to do this, I would like to note that there's already another Mixin library which at SpongePowered, we've developed for a little over a year now, and suffice to say that the power wielded with it is pretty substantial. Examples can be found in SpongeCommon and SpongeForge.

Note that I'm not dissuading you from developing your own mixin library, just, if it helps to speed up development to use an existing well tested library that does almost everything possible to remain mod compatible as possible while still wielding the power of injections and additions to Minecraft's code at runtime.

LunNova commented 8 years ago

Thanks for your interest. I had a discussion with @Mumfrey recently on IRC and can post a transcript if you want. Small excerpt regarding the naming

Sorry Mum_frey, I'll say mix_in for now. stole your project's name as it's an existing programming term, and made more sense than "PrePatcher". I can rename it to "TerribleHackyCodeInjectorThingamabob" if you want

This was meant as a joke, but if you do have more sensible ideas for an alternate name I'm happy to swap it over.

Unfortunately, SpongePowered/Mixin doesn't really match my needs - and I'm not sure it's intended to?

Things I needed (or do not necessarily need but strongly prefer to the implementation in SpongePowered/Mixin):

If adding this sort of behavior to SpongePowered/Mixin without interfering withe existing usecases is possible, I could swap to it but that sounds like a significant engineering effort for minimal benefit. I may also have misunderstood, and some of this behavior is already possible in SpongePowered/Mixin.