search

MinimallyCorrect / TickThreading

Historical multi-threaded minecraft by @LunNova. Performance over correctness. What could go wrong? Way too much.
https://jenkins.nallar.me/job/TickThreading/
MIT License
141 stars 43 forks source link

TickRegions contain wrong entities, entities in multiple TickRegions. #712

Closed alicheek closed 11 years ago

alicheek commented 11 years ago

Went there and there is nothing there but yet getting it as the highest place in the world for latency.

2013-06-12_17 37 29

darkdeath1332 commented 11 years ago

Coke ovens with world anchors make the time extremely high.

LunNova commented 11 years ago

Stand somewhere in the 0, 0 chunk and run /profile c.

alicheek commented 11 years ago

Its not doing it atm but ill do it and send it to you as soon as it does :)

alicheek commented 11 years ago

ok got it in the /ticks again so went to 0.70 0 then did /profile c and this is what I got (second picture is just me showing 0 0 being in the top /ticks):

2013-06-14_03 56 18 2013-06-14_03 56 43

alicheek commented 11 years ago

got it at 26 ms of latency which was the top of my list of course, seem to be dependant on the amount of people or the amount of work the server has to be doing, did another profile c and basically got the same though :

2013-06-14_21 21 57

weird thing is I did get this the time before though on chunk 0 0 :

2013-06-14_21 19 31 2013-06-14_21 19 04

LunNova commented 11 years ago

Get latest, and run with the -Dtickthreading.debug=true java parameter, before -jar.

If the issue still occurs, give the full tickthreading log file.

LunNova commented 11 years ago

While testing 1.5, found the problem. Something is seriously wrong with the TickRegion + TileEntity management code, managed to place a TileEntity in two TickRegions at the same time. Not good...

LunNova commented 11 years ago 
2013-06-18 23:40:30 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @2087502808 in Overworld/0 at x, y, z: 63, 29, 369
 In 0   .tickRegion: 1507331    expected: 1507331
2013-06-18 23:40:31 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityChest @116648995 in Overworld/0 at x, y, z: 139, 51, 359
 In 0   .tickRegion: 1441800    expected: 1441800
2013-06-18 23:40:31 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityChest @2133943521 in Overworld/0 at x, y, z: 137, 51, 357
 In 0   .tickRegion: 1441800    expected: 1441800
2013-06-18 23:40:31 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @1023850012 in Overworld/0 at x, y, z: 137, 51, 360
 In 0   .tickRegion: 1441800    expected: 1441800
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityChest @1356006715 in Overworld/0 at x, y, z: 210, 13, 212
 In 0   .tickRegion: 851981     expected: 851981
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityChest @1554419744 in Overworld/0 at x, y, z: 206, 13, 210
 In 0   .tickRegion: 851980     expected: 851980
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @1055361655 in Overworld/0 at x, y, z: 208, 13, 212
 In 0   .tickRegion: 851981     expected: 851981
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @2086777764 in Overworld/0 at x, y, z: 210, 26, 336
 In 0   .tickRegion: 1376269    expected: 1376269
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityChest @1097518662 in Overworld/0 at x, y, z: 221, 35, 399
 In 0   .tickRegion: 1572877    expected: 1572877
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @1206972365 in Overworld/0 at x, y, z: 222, 35, 397
 In 0   .tickRegion: 1572877    expected: 1572877
2013-06-18 23:40:32 [DEBUG] [TickThreading] A tile entity is in the wrong TickRegion - was it moved by a player, or did something break?
 entity: c net.minecraft.tileentity.TileEntityMobSpawner @872732300 in Overworld/0 at x, y, z: 248, 25, 342
 In 0   .tickRegion: 1376271    expected: 1376271
LunNova commented 11 years ago

Partially fixed in build 1961. Needs further changes to ensure it works correctly when added/removed from TickRegions concurrently.