search

Minishlink / web-push-bundle

Bundle around the WebPush library
MIT License
45 stars 10 forks source link

Make bundle compatible with Symfony 5 #14

Closed juliusstoerrle closed 4 years ago

juliusstoerrle commented 4 years ago

Update composer.json to include Symfony V5.

Fixes #13

I have NOT tested the changes yet.

Minishlink commented 4 years ago

Let me know when you have tested it, and I'll merge, thanks!

juliusstoerrle commented 4 years ago

As the TreeBuilder changed I had to update the code aswell. The constructor parameter of the TreeBuilder is only available since 4.2. I therefore also raised the minimum required symfony version to 4.2.

I think it is alright, but people still using symfony 3.4 will need to use a previous version of this library.

juliusstoerrle commented 4 years ago

I tested this branch with Symfony version 5 and it worked without problems so far. From my side it would be ready for a merge.