search

MinistryOfMagic / xunit.frameworks.autofac

Use Autofac to resolve xUnit test classes
MIT License
6 stars 3 forks source link

Prevent theories running exponentially #7

Closed dabide closed 2 years ago

dabide commented 3 years ago

Fixes #3

kemmis commented 3 years ago

No, I wouldn’t merge my PR. I don’t think it fixes the problem now.

On Mon, Oct 18, 2021 at 3:47 AM David A. Sjøen @.***> wrote:

@.**** commented on this pull request.

In src/Xunit.Frameworks.Autofac/TestFramework/AutofacTheoryTestCaseRunner.cs https://github.com/MinistryOfMagic/xunit.frameworks.autofac/pull/7#discussion_r730651383 :

  • protected override async Task AfterTestCaseStartingAsync()
  • {
  • }

Are you sure that overriding AfterTestCaseStartingAsync() with an empty method has no side effects, @kemmis https://github.com/kemmis ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MinistryOfMagic/xunit.frameworks.autofac/pull/7#pullrequestreview-781693823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6C6JHLLS5KCAAZ3FYDNDUHPGHNANCNFSM5GFUCT6A .

dabide commented 2 years ago

Fixed in #8