search

Minitour / AZTabBarController

A custom tab bar controller for iOS written in Swift 4.2
MIT License
348 stars 65 forks source link

Multiple issues #58

Closed and0m closed 5 years ago

and0m commented 5 years ago

Initially, I thought the problem is within my app, but then I tried the example, which has the same issue. Basically, when a user clicks multiple times on the buttons it seems that sometimes the toggle fails. Sometimes the app switches to a completely different view (usually the home).

A way to replicate the behavior would be to click on the "feed" tab, from the example project, in multiple succession (almost like rage clicking it).

I assume this is due to the views being stacked on top of each other. I don't really know what's going on.

Another issue that I'm facing is that the AZTabController seems to be on top of everything in my view and screws up element interaction. There is another issue related to this bug but the suggestion didn't solve my problem. Seems like the TabController is messing up the NavigationController.

Better documentation will be really helpful...

iDevelopper commented 5 years ago

I think your last point this is relative to the additional safe area inset that is missing, because this class is not a UITabBarController subclass and the framework does not provide anything for additional safe area inset...

and0m commented 5 years ago

safe area inset

Thanks for the heads up. Indeed, one of my views didn't have a proper safe area setup. That fixed the problem.

iDevelopper commented 5 years ago

Great!

Minitour commented 5 years ago

@and0m

Initially, I thought the problem is within my app, but then I tried the example, which has the same issue. Basically, when a user clicks multiple times on the buttons it seems that sometimes the toggle fails. Sometimes the app switches to a completely different view (usually the home).

A way to replicate the behavior would be to click on the "feed" tab, from the example project, in multiple succession (almost like rage clicking it).

I assume this is due to the views being stacked on top of each other. I don't really know what's going on.

I could not reproduce this behaviour. Can you tell me which device were you using? was it simulator or a real device, and if it was a real device then what was it's model as well as which iOS version did you run it on.