MinnDevelopment / fxreddit

Provides improved reddit embeds for services such as Discord.
https://rxddit.com
Apache License 2.0
125 stars 6 forks source link

Doesn't seem to work with Telegram #52

Closed ZornTaov closed 1 week ago

ZornTaov commented 8 months ago

https://rxddit.com/r/virtualreality/comments/19dpmuf/spatial_vacuuming/ this link works on discord, embedding as a video, but on telegram it shows up as the usual reddit watermarked embed preview image like it would with a regular reddit link.

optionsx commented 6 months ago

yep^ i suppose adding telegram useragent to ur list of allowed useragents, would be nice

MinnDevelopment commented 6 months ago

I'm open for a PR to make this happen.

pwall2222 commented 1 week ago

Maybe if you remove https://github.com/MinnDevelopment/fxreddit/blob/ebd68f3cbbddac921b4952f69c84b099493fcada/src/endpoints/post.ts#L34 this line it would work on Telegram, since fxtwitter doesn't have the <meta http-equiv="Refresh" content="0; URL=[url]"> And it works fine in Telegram. @MinnDevelopment

sjain882 commented 1 week ago

https://github.com/dylanpdx/vxReddit this one works with telegram!

MinnDevelopment commented 1 week ago

I've removed the http equiv meta tag, does that resolve this issue?

sjain882 commented 1 week ago

Screenshot_20240922_142832_Nagram~2

https://www.rxddit.com/r/london/comments/1fllaua/certified_tfl_moment/

Seems to work with sound, yes. As for the varying formats and full audio support with those, will probably need more testing. Thanks for the update!

MinnDevelopment commented 1 week ago

Audio support is limited, since Reddit doesn't generally provide videos with audio. And since this is hosted on Cloudflare workers, re-encoding videos is not possible.

If you encounter any specific issues besides missing audio, feel free to open a new issue.