MinnPost / jquery-vertical-timeline

jQuery plugin of: A beautiful vertical timeline made with Tabletop.js, Isotope.js & Handerlbarz.js. A collaboration between Balance Media and WNYC/John Keefe.
http://code.minnpost.com/jquery-vertical-timeline/
Other
122 stars 27 forks source link

Year placement is wrong #2

Open stevesuo opened 11 years ago

stevesuo commented 11 years ago

When I sort Oldest First in this example, an entry for January 1, 1985 ends up being placed after the year heading for 1979 and before the year heading for 1985. I don't think this is the expected behavior. Here is the spreadsheet I am using:

https://docs.google.com/spreadsheet/pub?key=0AqSrygWv7Qj3dDVDZHBqVTdFNFBOSU5NSmtrOEZHLUE&output=html

zzolo commented 11 years ago

Hey Steve. As the README says, the data field is very particular; try updating this. https://github.com/MinnPost/jquery-vertical-timeline#data

stevesuo commented 11 years ago

Way cool that you responded so fast and way cool project. I will try the fix tomorrow.

Sent from my iPhone

On May 9, 2013, at 6:43 PM, Alan Palazzolo notifications@github.com wrote:

Hey Steve. As the README says, the data field is very particular; try updating this. https://github.com/MinnPost/jquery-vertical-timeline#data

— Reply to this email directly or view it on GitHub.

stevesuo commented 11 years ago

I followed the instructions in README, made the dates January 1, 1985 etc. and all columns are plain text. The issue persists when sorted oldest to newest.

stevesuo commented 11 years ago

Please try the example sheet that I referenced earlier. It contains to reformatted dates.

zzolo commented 11 years ago

Hey Steve. Do you have your code anywhere I can look at it?

stevesuo commented 11 years ago

Heya. I simply cloned the repo to my test site, frogmine.com. The blog entry that points to the javascripts is as follows (copied directly from the example shown on GitHub):

Vertical Timeline

On Fri, May 10, 2013 at 12:35 PM, Alan Palazzolo notifications@github.comwrote:

Hey Steve. Do you have your code anywhere I can look at it?

— Reply to this email directly or view it on GitHubhttps://github.com/MinnPost/jquery-vertical-timeline/issues/2#issuecomment-17740180 .

-- Steve

zzolo commented 11 years ago

The code you pasted seems to work fine, though the spreadsheet is different.

If I try with your original spreadsheet above, it does behave oddly. I am not sure what the issue, but would need to spend more time with a spreadsheet I can edit before I can figure it out.

stevesuo commented 11 years ago

Alan,

Thank you so much for taking all the time to help. I just put the example pointing to the correct spreadsheet here:

http://frogmine.com/jquery-vertical-timeline/example.html

I confirmed from this that there's nothing on the oregonlive.com site that is causing the problem -- I still get odd behavior on frogmine.com.

If you give me an email address, I can give you edit access to the Google document. I will make a backup. You seem like a trustworthy type, though. :)

Steve

On Fri, May 10, 2013 at 1:05 PM, Alan Palazzolo notifications@github.comwrote:

The code you pasted seems to work fine, though the spreadsheet is different.

If I try with your original spreadsheet above, it does behave oddly. I am not sure what the issue, but would need to spend more time with a spreadsheet I can edit before I can figure it out.

— Reply to this email directly or view it on GitHubhttps://github.com/MinnPost/jquery-vertical-timeline/issues/2#issuecomment-17741550 .

-- Steve

zzolo commented 11 years ago

Hey Steve. Finally got around to looking at this. There is definitely a bug, but I have not identified the actual issue. It may be a matter of timezone offsets.

You can get around it by using something like "January 02, 1994" instead of Jan 1 and it should sort the way you want it to. I'll keep looking to find what the actual bug is.

stevesuo commented 11 years ago

Thanks so much! My Plan B was to try display:none on the sort buttons -- because the sort worked fine descending but not ascending -- but that kind of eliminates a core piece of the functionality you created.

I'll try the workaround.

Steve

On Thu, May 23, 2013 at 12:56 PM, Alan Palazzolo notifications@github.comwrote:

Hey Steve. Finally got around to looking at this. There is definitely a bug, but I have not identified the actual issue. It may be a matter of timezone offsets.

You can get around it by using something like "January 02, 1994" instead of Jan 1 and it should sort the way you want it to. I'll keep looking to find what the actual bug is.

— Reply to this email directly or view it on GitHubhttps://github.com/MinnPost/jquery-vertical-timeline/issues/2#issuecomment-18367794 .

-- Steve