MinnPost / jquery-vertical-timeline

jQuery plugin of: A beautiful vertical timeline made with Tabletop.js, Isotope.js & Handerlbarz.js. A collaboration between Balance Media and WNYC/John Keefe.
http://code.minnpost.com/jquery-vertical-timeline/
Other
122 stars 27 forks source link

support group by Month and Day #7

Closed hupili closed 10 years ago

hupili commented 11 years ago

This address the 3rd point of #4. Thanks for the guide.

There are some extra blanks cleared out automatically by the editor.

Here's the running demo:

http://hupili.net/tl-social.html

zzolo commented 11 years ago

Thanks for the pull request @hupili. This didn't actually need to be a pull request as the configuration options supports using actual functions; there just happens to be a couple that are included with the library.

But, it doesn't hurt to have them. You have a things that need to be updated in this pull request before I can accept it.

hupili commented 11 years ago

@zzolo , thanks for the guide. I addressed (2) and (3).

For the CSS, the block is wider if you use month segment (Aug 2013) or day segment (7 Aug, 2013). I have to add 30+ px to keep the texts inside the block. Otherwise, it overflows. Can you advise a better position to do this? Thanks.

zzolo commented 11 years ago

Hey @hupili. I see your point, but given that CSS is easily overridable, the goal of this application is to have sensible defaults which I believe it already does. So, people can override the CSS when they use the application. If you want, you could add a note in the README for the config value, but I really don't think we need to alter the styles in the core application.

zzolo commented 10 years ago

I just manually put this in there. Thanks.