search

MinnPost / jquery-vertical-timeline

jQuery plugin of: A beautiful vertical timeline made with Tabletop.js, Isotope.js & Handerlbarz.js. A collaboration between Balance Media and WNYC/John Keefe.
http://code.minnpost.com/jquery-vertical-timeline/
Other
122 stars 27 forks source link

Issue #5: icon/thumbnail support #8

Closed chugcup closed 10 years ago

chugcup commented 10 years ago

Allows for a small "favicon" to be included in the title of posts. Uses 'title_icon' field in JSON data object.

Also included some default CSS to size the icon to 20x20 pixels, but this can always be managed in the stylesheet

zzolo commented 10 years ago

Hey @chugcup. This is a cool idea and thanks for the pull request. Unfortunately, there is lots of other changes in here for some reason, so I can't merge it or even fully understand the real set of changes you are trying to make. If you create a pull request that is just the changes for this feature, then I can review and hopefully merge in. Thanks!

chugcup commented 10 years ago

Huh. I only aimed to push the commits 97e4476 and 3220b54 back into the upstream, which should only contain the favicon addition and possibly some whitespace cleanup.

The other commits are for a personal fork I have been working on that may or may not ever find its way back... I'm not sure why they are showing up here because I initiated the push request before committing those

I'll see if I can try and just push those 2 commits