search

MinnPost / minnpost-largo

Largo child theme for MinnPost
GNU General Public License v3.0
2 stars 0 forks source link

Text (or other icon?) fallbacks for Font Awesome icons #156

Open jonathanstegall opened 3 years ago

jonathanstegall commented 3 years ago

Sometimes the Font Awesome API fails to respond. I think we should have a fallback for the icons that aren't already accompanied by text labels. For example the donate button has an icon, but it also has text so we don't have to worry as much about it.

But specifically the search icon, the account icon, the arrow nav icons, and the social icons do not currently have fallbacks if the icon API goes down.

As in the header nav:

image
jonathanstegall commented 3 years ago

Maybe we could figure out if it's possible to use the SVG icons that are used in Gutenberg.

jonathanstegall commented 3 years ago

We could also try building Font Awesome into the theme, instead of using the plugin. Would need to make sure this doesn't cause conflicts with plugins that are using Font Awesome though. https://fontawesome.com/how-to-use/customizing-wordpress/intro/getting-started