search

MinnPost / minnpost-membership

WordPress plugin for membership stuff
GNU General Public License v2.0
1 stars 1 forks source link

Disable swag by level #40

Closed krbullock closed 5 years ago

krbullock commented 5 years ago

Lots of room for improvement and cleanup here, so let me know what you'd like me to tweak.

jonathanstegall commented 5 years ago

At first I didn't realize that items users aren't eligible for were disabled. The appearance change is very subtle, and the language still makes it seem like the user can pick it. Have we discussed how to make this a usable display? I see the tooltip, but I'm not sure that is noticeable enough.

I think I get the benefit of keeping them visible, since maybe it might cause users to upsell (is that the idea?), but I think we might also need to add some static language. Maybe the line that says "Also choose if you want one or both of these subscriptions:" would need to change what it says? And also the "decline both subscriptions" since they wouldn't be declining two. It just doesn't seem as clear as an overall flow users would go through, to me.

I'm also noticing a browser issue. It does not happen in Firefox or Safari but it does happen in Chrome (I haven't tested other browsers): when I click a thank you gift, or when I click one of the preselected items, the browser takes me back up to the top of the page instead of leaving me at my current scroll position like it should.

krbullock commented 5 years ago

@jonathanstegall thanks for the review! I'll look into the Chrome issue and check w/Bridget about the usability issues you bring up.

jonathanstegall commented 5 years ago

I think we can go ahead and merge, with the understanding that we can figure out what to do with the text transitions.