Upgrade ActionScheduler library to version 3.2

MinnPost / object-sync-for-salesforce

WordPress plugin that maps and syncs data between Salesforce objects and WordPress objects.

https://wordpress.org/plugins/object-sync-for-salesforce/

GNU General Public License v2.0

94 stars 51 forks source link

Upgrade ActionScheduler library to version 3.2 #395

Closed jonathanstegall closed 3 years ago

jonathanstegall commented 3 years ago

What does this Pull Request do?

When it is merged, this pull request will close #299 and upgrade our installation of the ActionScheduler library to version 3.2. This will start several processes that the library runs to upgrade itself. Read about that process on their site.

How do I test this Pull Request?

take a database backup of your site
enable WordPress debugging if it isn't already enabled
go to the /wp-admin/tools.php?page=action-scheduler URL in your WordPress install after checking out this branch
basically just watch what it says, and compare with what the documentation link above says
if you have database access, make sure it creates and popuulates the new tables: wp_actionscheduler_actions, wp_actionscheduler_claims, wp_actionscheduler_groups, and wp_actionscheduler_logs (current as of 5/19/21).
check your PHP error logs for anything relevant

jonathanstegall commented 3 years ago

Locally on my laptop, according to the /wp-admin/tools.php?page=action-scheduler URL indicator that migration is still happening, the migration started at 9:45am and finished at 10:25am. No other WordPress tasks were happening. As far as I can tell, it didn't run into any errors but I have no idea what it may have missed getting from Salesforce, for example.

jonathanstegall commented 3 years ago

It seemed like it didn't run any of the plugin's scheduled tasks until I went to the plugin schedule settings and changed the frequency (from 5 to 10 minutes, though I then changed it back to 5). Perhaps it had to recreate something.

If this is the case, we should try to include this in the plugin when it realizes the version change, but I'm not really sure when it should do that. It might also have been a fluke in my case, but I do think that is unlikely.

jonathanstegall commented 3 years ago

It didn't run after that on schedule, just a manual pull. So I think I might also have had a cron problem locally. I installed WP-Crontrol, and then it started running plugin tasks as I would have expected.

jonathanstegall commented 3 years ago

I think this got significantly more reliable on my laptop with version 3.2.0. I'm not sure why that is though.

minncodebot commented 3 years ago

GitHub API communication error. Please contact a human. (commit-ID: 6ec4839b1e9e91f36488428a9c8770329ad4cf3f).