Duplicate mapping of fields was prevented when it shouldn't be. Thanks to @timnolte for the report. - Githubissues

MinnPost / object-sync-for-salesforce

WordPress plugin that maps and syncs data between Salesforce objects and WordPress objects.

https://wordpress.org/plugins/object-sync-for-salesforce/

GNU General Public License v2.0

94 stars 51 forks source link

Duplicate mapping of fields was prevented when it shouldn't be. Thanks to @timnolte for the report. #416

Closed jonathanstegall closed 3 years ago

jonathanstegall commented 3 years ago

What does this Pull Request do?

This fixes #415 by only disabling already mapped fields when the setting is enabled, as it should be.

How do I test this Pull Request?

bug fix

Ensure the new "Prevent Duplicate Field Mapping?" option is unchecked.
Add/edit a Field Mapping.
Map some WordPress fields to Salesforce.
Save & reload the Field Mapping.
Fields already mapped should be selectable.

that the option still works

Ensure the new "Prevent Duplicate Field Mapping?" option is checked.
Add/edit a Field Mapping.
Map some WordPress fields to Salesforce.
Save & reload the Field Mapping.
Fields already mapped should not be selectable.

timnolte commented 3 years ago

@jonathanstegall tested locally and things are working as expected.