MinnPost / object-sync-for-salesforce

WordPress plugin that maps and syncs data between Salesforce objects and WordPress objects.
https://wordpress.org/plugins/object-sync-for-salesforce/
GNU General Public License v2.0
94 stars 51 forks source link

Fix missing Record Type when pulled from Salesforce. Thanks to @timnolte for the report. #419

Closed jonathanstegall closed 2 years ago

jonathanstegall commented 2 years ago

What does this Pull Request do?

This fixes #418.

After upgrading to the 2.x version of the plugin I have found that specifically in the case where I have multiple mappings for a Salesforce Object to a WordPress Object, because of multiple Salesforce record Types, that when those records from Salesforce are being processed the resulting WordPress Post Type ends up being set as post, when logs and debug processing indicate that it should have created a Custom Post Type (e.g. sf_industry_location). I verified that reverting back to the 1.9.9 version of the plugin restored the proper WordPress Post Type is created.

How do I test this Pull Request?

timnolte commented 2 years ago

@jonathanstegall FYI, this changes fixes the issue. If there is any chance you could get this into 2.0.3 yet today that would be amazing. Upgrading to 2.x, disregarding this issue atm, fixes another blocker I'm hitting with 1.9.9 right now.

jonathanstegall commented 2 years ago

@timnolte For sure, I'll try to get that released shortly.

timnolte commented 2 years ago

@jonathanstegall actually, no rush. I'm just going to apply a patch upon install of the plugin until you are ready to push out a release. That way you have time to include anything more before another release.