Messenger crashing upon opening chat head with "Lock conversations" option ON

Mino260806 / MessengerPro

A mod that enhances Facebook Messenger with loads of powerful features !

515 stars 40 forks source link

Messenger crashing upon opening chat head with "Lock conversations" option ON #35

Open racked23 opened 1 year ago

racked23 commented 1 year ago

The steps to reproduce are simple; just enable "Lock conversations" and try manually opening a chat head from a conversation. It will first show you the biometric verification pop-up, then crash 1 second later.

My suggestion would be either to add an a option so it disables the verification on chat heads, or just fix the crash and make it always pop up no matter what, which would be a pain. (Or make both possible).

Mino260806 commented 11 months ago

What's the point of having the verification at the first place if you can just see the conversation in chat heads ? I think a workaround is to just disable chat heads because the verification will always be raising problems with chat heads...

racked23 commented 11 months ago

Wouldnt it be better to not show the chat until you verified yourself ?

Mino260806 commented 11 months ago

Wouldnt it be better to not show the chat until you verified yourself ?

Now I read the description again because I was mislead by the title. Yes it's possible, but there are many problems:

My fingerprint is broken so I can no longer test this feature until I can make it work in the emulator
And the main one: it's going to be costly to let the mod interact with messenger ui which changes constantly and is very hard to predict, so I'll welcome a PR if someone can have a sustainable implementation, and until then, I can't unfortunately help.