MinoMino / minqlbot-plugins

A collection of plugins for minqlbot.
GNU General Public License v3.0
5 stars 10 forks source link

nick search on !elo #5

Open WalkerY opened 9 years ago

WalkerY commented 9 years ago

[14:36] Mino: I strongly suggest to add nickname completion to !elo command. I have done it here: https://gist.github.com/WalkerY/34d8a3c96d44ddc3f95f [14:36] Very helpful and improves consistency with !spec !red and others [14:38] also it might be useful to make it clear in usage for example by using "fullnick" and "nick" to emphasize when full nick is needed.

MinoMino commented 9 years ago

I'd argue that using Plugin.find_player() in this instance would be the a case of inconsistency considering I've been consistent about not using it in cases where one would might want to use the command on someone that isn't present on the server, without the chance of it tripping up due to the players on the server. I realize the chances of this happening are fairly slim, so I'll consider doing it. Leaving the issue open for now.