search

MinoMino / minqlx

Extends Quake Live's dedicated server with extra functionality and scripting.
GNU General Public License v3.0
112 stars 42 forks source link

permit tjone270/branding.py to show map credits #33

Closed tjone270 closed 8 years ago

tjone270 commented 8 years ago

With my branding.py plugin (https://github.com/tjone270/Quake-Live/blob/master/minqlx-plugins/branding.py), I'd like to be able to show the original map author lines before the user-set branding. When I use the same method above to do so (lines 221/231, how you keep the author names before your minqlx branding), I get both the map credits, and the minqlx branding, and the branding set by the plugin user.

If there's a cvar (qlx_minqlxSelfBrand in this case) that can disable your branding, I can then use the map credits with branding.py.

tjone270 commented 8 years ago

https://github.com/tjone270/Quake-Live/commit/b272a2845832d40942233f91e44a8c070acd88fd

This is how I've changed branding.py to fit in with this.

MinoMino commented 8 years ago

I think I want to take another approach for this one. I think I'll save the map title and the two configstrings before setting them, then make Game.map_title and two additional new properties return these so that any changes, including mine, doesn't affect it. That would fix the issue with Game.map_title not being the actual map name as well as allowing your plugin to properly credit the makers.

tjone270 commented 8 years ago

Sounds like a good idea.

Can the new properties be called: game.map.author1 and game.map.author2?

Thanks :)

MinoMino commented 8 years ago

Game.map is just a string, so in order to do that I would have to make a class or something like that, which is overkill. Instead I'll follow the same pattern I've used so far with the map name. Game.map_title, Game.map_subtitle1 and Game.map_subtitle2.

tjone270 commented 8 years ago

No problem, thanks Mino :D

On 21/01/2016 11:36 AM, Mino wrote:

|Game.map| is just a string, so in order to do that I would have to make a class or something like that, which is overkill. Instead I'll follow the same pattern I've used so far with the map name. |Game.map_title|, |Game.map_subtitle1| and |Game.map_subtitle2|.

— Reply to this email directly or view it on GitHub https://github.com/MinoMino/minqlx/pull/33#issuecomment-173423594.

MinoMino commented 8 years ago

Implemented in dab3e4a865222a0ae441a41caa0c0e3dcd3f8e69.