Update the Makefile to be compatible with Python 3.8

MinoMino / minqlx

Extends Quake Live's dedicated server with extra functionality and scripting.

GNU General Public License v3.0

112 stars 42 forks source link

Update the Makefile to be compatible with Python 3.8 #96

Closed dr-traktor closed 4 years ago

dr-traktor commented 4 years ago

The usage of python3-config has changed in Python 3.8 as described in [1].

The suggested way by the authors to treat this in a backward compatible fashion is to try the 3.8 command python3-config --libs --embed and if it fails (because the installation is pre 3.8), then execute python3-config --libs.

The $(.SHELLSTATUS) variable requries GNU Make >= 4.2 (released on 2016-05-22).

[1] https://docs.python.org/3.8/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

em92 commented 4 years ago

Hi, @dr-traktor ! I made a commit some time ago https://github.com/MinoMino/minqlx/commit/284a6e73f077ebfd495335ea44ee7286f1be5a3e But I forgot to push it here.

em92 commented 4 years ago

The $(.SHELLSTATUS) variable requries GNU Make >= 4.2 (released on 2016-05-22).

Checked, which version is installed in debian stretch, which is mentioned in minqlx install instructions. It uses make version of 4.1. https://packages.debian.org/stretch/make

In any case, thanks for catching the issue!