Minoru / hakyll-convert

Import from other blog engines to Hakyll
Other
7 stars 0 forks source link

Test suite fails with tasty 1.4 #47

Closed Minoru closed 3 years ago

Minoru commented 3 years ago

We have two tests that ensure error gets called in some edge cases. Those tests use tasty-expected-failure to catch the exception and turn the failure into an "expected failure", making the test suite pass. However, with tasty 1.4 this no longer works: the exceptions propagate past tasty-expected-failure and fail the tests.

Our version bounds disallow tasty 1.4, so our users are fine. However, Stackage is looking to upgrade to tasty 1.4 (https://github.com/commercialhaskell/stackage/issues/5795), and this incompatibility might prevent hakyll-convert from being included in there.

I filed https://github.com/nomeata/tasty-expected-failure/issues/24 in hopes that the developers of tasty-expected-failure might have some ideas of what's going on, so I can fix the issue before we're booted from Stackage.