Closed AtomCrafty closed 2 years ago
I'm not sure about this one since the value of args_disass/assembly are just the arguments of an (dis-)assemly instruction. Renaming it would imply a different meaning...
I think assembly
makes sense, even though you currently only use it as a format string for a disassembler.
encoding
specifies the binary representation, and assembly
the textual one. I'd expect that the compiler people need something like this once when they start looking into generating ISAX support from CoreDSL.
Those changes also need to be reflected in the wiki
Those changes also need to be reflected in the wiki
Yup, I'll take care of that.
Depends on #20
This is just a proposal, feel free to ignore it if you prefer the current style. I believe the
args_disass
keyword is very ugly, andassembly
happens to have just the right length to make all three keywords in an instruction definition line up perfectly: